adding ember-cli-meta-tags npm package to provide meta descriptions#427
Merged
alexcrichton merged 1 commit intorust-lang:masterfrom Aug 31, 2016
ducks:add-meta-descriptions
Merged
adding ember-cli-meta-tags npm package to provide meta descriptions#427alexcrichton merged 1 commit intorust-lang:masterfrom ducks:add-meta-descriptions
alexcrichton merged 1 commit intorust-lang:masterfrom
ducks:add-meta-descriptions
Conversation
…ptions for each page
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #425
first pass at adding meta descriptions
This PR adds the ember-cli-meta-tags module. It also adds a head template. This is needed when using multiple modules using ember-cli-head which we now are.
There is an entry for the index route to have a meta description tag at
app/routes/index.js.This can be added to any route by adding an object:
this produces:
<meta id="ember823" content="cargo is the package manager and crate host for rust" name="description" class="ember-view">Feedback and thoughts on other page descriptions most appreciated.