Skip to content

adding ember-cli-meta-tags npm package to provide meta descriptions #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2016
Merged

adding ember-cli-meta-tags npm package to provide meta descriptions #427

merged 1 commit into from
Aug 31, 2016

Conversation

ducks
Copy link

@ducks ducks commented Aug 30, 2016

refs #425

first pass at adding meta descriptions

This PR adds the ember-cli-meta-tags module. It also adds a head template. This is needed when using multiple modules using ember-cli-head which we now are.

There is an entry for the index route to have a meta description tag at app/routes/index.js.
This can be added to any route by adding an object:

headTags: [{
    type: 'meta',
    attrs: {
        name: 'description',
        content: 'cargo is the package manager and crate host for rust'
    }
}],

this produces:
<meta id="ember823" content="cargo is the package manager and crate host for rust" name="description" class="ember-view">

Feedback and thoughts on other page descriptions most appreciated.

@alexcrichton
Copy link
Member

Nice!

@alexcrichton alexcrichton merged commit ee5f657 into rust-lang:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants